-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] Remove rate limit field from services API for EIS #135838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (Team:ML) |
Hi @davidkyle, I've created a changelog YAML for you. |
Oops. Removing the rate limiting from EIS was done in 9.2 Do we want to backport it to 9.1? I don't think there's any harm in removing it from the UI but technically it's still configurable in the UI in 9.1. |
I removed the backport label |
jonathan-buttner
approved these changes
Oct 8, 2025
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 9, 2025
The Elastic Inference Service does not accept a rate limit setting and should not be declared in service configuration.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Elastic Inference Service does not accept a rate limit setting but the service configuration declares that rate limit is a configurable field. This causes an error when creating an EIS endpoint in the UI
This PR removes the rate limit field from the service configuration.